Skip to content

simplify hyperion restart#1744

Merged
rtuck99 merged 9 commits into
mainfrom
1737_simplify_hyperion_restart
Jun 15, 2026
Merged

simplify hyperion restart#1744
rtuck99 merged 9 commits into
mainfrom
1737_simplify_hyperion_restart

Conversation

@rtuck99

@rtuck99 rtuck99 commented May 11, 2026

Copy link
Copy Markdown
Contributor

Fixes

Also requires

Link to dodal PR (if required): #N/A

As used from GDA, hyperion_restart() should always kill all hyperion processes, however separate launching of supervisor and blueapi is retained for use direct from the command line via run_hyperion.sh.
Blueapi is now started in a separate process group to avoid being sent the SIGINT by gda_launcher which was terminating the process on GDA server shutdown.

Checks for reviewer

  • Would the PR title make sense to a user on a set of release notes

rtuck99 added 3 commits May 11, 2026 13:02
Widen scope to find processes regardless of parent directory name
Fix vanilla UDC not always stopped
@rtuck99 rtuck99 added the hyperion Issues for Hyperion, the Bluesky UDC stack label May 11, 2026
@codecov

codecov Bot commented May 11, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.02%. Comparing base (e82beb7) to head (96627e3).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1744   +/-   ##
=======================================
  Coverage   93.02%   93.02%           
=======================================
  Files         164      164           
  Lines        8918     8918           
=======================================
  Hits         8296     8296           
  Misses        622      622           
Components Coverage Δ
i24 SSX 77.15% <ø> (ø)
hyperion 98.74% <ø> (ø)
other 98.16% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@rtuck99 rtuck99 changed the title 1737 simplify hyperion restart simplify hyperion restart May 12, 2026
@rtuck99 rtuck99 marked this pull request as ready for review May 12, 2026 13:27
@rtuck99 rtuck99 requested a review from a team as a code owner May 12, 2026 13:27

@adaudon adaudon left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Is it not possible or unnecessary to add testing for bash scripts like this?

@rtuck99

rtuck99 commented Jun 15, 2026

Copy link
Copy Markdown
Contributor Author

Looks good. Is it not possible or unnecessary to add testing for bash scripts like this?

Traditionally we haven't had unit tests for bash scripts, I suppose in theory it might be possible to test bash scripts, although I haven't looked into what frameworks exist for it. In general it's fairly complicated as we don't currently have any infrastructure for it.

Long term we are looking to move away from this though as once containerised we won't need complex bash scripts like this.

@rtuck99 rtuck99 enabled auto-merge (squash) June 15, 2026 09:51
@rtuck99 rtuck99 merged commit e4a2084 into main Jun 15, 2026
10 of 11 checks passed
@rtuck99 rtuck99 deleted the 1737_simplify_hyperion_restart branch June 15, 2026 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hyperion Issues for Hyperion, the Bluesky UDC stack

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants