simplify hyperion restart#1744
Conversation
Widen scope to find processes regardless of parent directory name
Fix vanilla UDC not always stopped
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1744 +/- ##
=======================================
Coverage 93.02% 93.02%
=======================================
Files 164 164
Lines 8918 8918
=======================================
Hits 8296 8296
Misses 622 622
🚀 New features to boost your workflow:
|
adaudon
left a comment
There was a problem hiding this comment.
Looks good. Is it not possible or unnecessary to add testing for bash scripts like this?
Traditionally we haven't had unit tests for bash scripts, I suppose in theory it might be possible to test bash scripts, although I haven't looked into what frameworks exist for it. In general it's fairly complicated as we don't currently have any infrastructure for it. Long term we are looking to move away from this though as once containerised we won't need complex bash scripts like this. |
Fixes
hyperion_restart()for blueapi #1737Also requires
Link to dodal PR (if required): #N/A
As used from GDA,
hyperion_restart()should always kill all hyperion processes, however separate launching of supervisor and blueapi is retained for use direct from the command line viarun_hyperion.sh.Blueapi is now started in a separate process group to avoid being sent the SIGINT by
gda_launcherwhich was terminating the process on GDA server shutdown.Checks for reviewer