Skip to content

Fixes for low FPS on slower systems during battles #3580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
VannevarXbox wants to merge 3 commits into
base: master
Choose a base branch
from
+341 −134
Open

Fixes for low FPS on slower systems during battles #3580

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
00bc932
Refactored Window_BattleStatus::Refresh and Window::BattleStatus.Refr…
VannevarXbox Jun 20, 2026
e30cc1b
Redraw the whole area if any actors have been added, removed, or chan…
VannevarXbox Jun 20, 2026
84111b7
Streamlined Window_Battlestatus caching struct, now only clear full a…
VannevarXbox Jun 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 0 additions & 32 deletions src/window_base.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -302,38 +302,6 @@ void Window_Base::DrawCurrencyValue(int money, int cx, int cy) const {
contents->TextDraw(cx - gold_text_size.width, cy, Font::ColorDefault, gold.str(), Text::AlignRight);
}

void Window_Base::DrawGauge(const Game_Battler& actor, int cx, int cy, int alpha) const {
BitmapRef system2 = Cache::System2();
if (!system2) {
return;
}

bool full = actor.IsAtbGaugeFull();

// Which gauge (0 - 2)
int gauge_y = 32 + 2 * 16;

// Three components of the gauge
Rect gauge_left(0, gauge_y, 16, 16);
Rect gauge_center(16, gauge_y, 16, 16);
Rect gauge_right(32, gauge_y, 16, 16);

Rect dst_rect(cx + 16, cy, 25, 16);

contents->Blit(cx + 0, cy, *system2, gauge_left, alpha);
contents->Blit(cx + 16 + 25, cy, *system2, gauge_right, alpha);
contents->StretchBlit(dst_rect, *system2, gauge_center, alpha);

const auto atb = actor.GetAtbGauge();
const auto gauge_w = 25 * atb / actor.GetMaxAtbGauge();
if (gauge_w > 0) {
// Full or not full bar
Rect gauge_bar(full ? 64 : 48, gauge_y, 16, 16);
Rect bar_rect(cx + 16, cy, gauge_w, 16);
contents->StretchBlit(bar_rect, *system2, gauge_bar, alpha);
}
}

void Window_Base::DrawActorHpValue(const Game_Battler& actor, int cx, int cy) const {
contents->TextDraw(cx, cy, GetValueFontColor(actor.GetHp(), actor.GetMaxHp(), true), std::to_string(actor.GetHp()), Text::AlignRight);
}
Expand Down
1 change: 0 additions & 1 deletion src/window_base.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,6 @@ class Window_Base : public Window {
void DrawItemName(const lcf::rpg::Item& item, int cx, int cy, bool enabled = true) const;
void DrawSkillName(const lcf::rpg::Skill& skill, int cx, int cy, bool enabled = true) const;
void DrawCurrencyValue(int money, int cx, int cy) const;
void DrawGauge(const Game_Battler& actor, int cx, int cy, int alpha = 255) const;
void DrawActorHpValue(const Game_Battler& actor, int cx, int cy) const;
void DrawActorSpValue(const Game_Battler& actor, int cx, int cy) const;
int GetValueFontColor(int have, int max, bool can_knockout) const;
Expand Down
Loading