Skip to content

[codex] Add PowerShell PR checks for GraphEssentials#16

Merged
PrzemyslawKlys merged 2 commits into
masterfrom
codex/add-pr-checks
Mar 30, 2026
Merged

[codex] Add PowerShell PR checks for GraphEssentials#16
PrzemyslawKlys merged 2 commits into
masterfrom
codex/add-pr-checks

Conversation

@PrzemyslawKlys

Copy link
Copy Markdown
Member

What changed

  • added a GitHub Actions workflow that runs on push and pull request to master
  • added a repo-level GraphEssentials.Tests.ps1 runner modeled after the simpler DnsClientX pattern
  • added focused Pester coverage for Graph error parsing, graceful PIM history fallback, throttled batch retry behavior, and manifest structure
  • configured the workflow to run the test suite in both Windows PowerShell 5.1 and PowerShell 7

Why

GraphEssentials previously had no CI checks on pull requests, so regressions in error handling and batch behavior could merge without any automated signal.

Validation

  • pwsh -NoProfile -File .\GraphEssentials.Tests.ps1
  • powershell -NoProfile -File .\GraphEssentials.Tests.ps1

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: a18e77235f

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +12 to +14
pull_request:
branches:
- master

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Trigger workflow on main instead of master

This workflow is scoped to master, but this repository’s active development branch is main (the branch with recent merge commits), so PRs targeting main will not run these new checks. That means the intended PR gate is effectively disabled unless someone runs workflow_dispatch manually, which defeats the purpose of adding automated regression checks.

Useful? React with 👍 / 👎.

@PrzemyslawKlys PrzemyslawKlys merged commit 64e1937 into master Mar 30, 2026
2 checks passed
@PrzemyslawKlys PrzemyslawKlys deleted the codex/add-pr-checks branch March 30, 2026 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant