Update to a more modern BLAS detector#396
Merged
Merged
Conversation
stephankramer
approved these changes
Jun 9, 2026
stephankramer
left a comment
stephankramer
left a comment
Contributor
There was a problem hiding this comment.
Looks good!
Just to double check:
- is it indeed the case that in libadaptivity we only call blas in libadaptivity/include/cxxblas.h via
extern "C", i.e. we don't need to test for fortran or CXX - the ax_blas/lapack that are used by fluidity's main configure is already up-to-date (enough)?
Contributor
Author
|
Yes, it's only in the C++ code with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The BLAS autoconf detector macros are out of date. This causes issues with libraries like FlexiBlas which is provided with EasyBuild - it will be simpler to find libraries with these changes. The detection will have to run in C mode rather than Fortran mode but that shouldn't cause any issues. I think this fixes #294.
Updated to the latest versions from autoconf-archive and run autoconf to generate a new configure.