Conversation
…verflows - Add NULL check for SteamNetworkingSockets() before calling methods (fixes PRIV_INSTRUCTION crash) - Replace unsafe sprintf() with snprintf() in WinMain.cpp to prevent buffer overflows - Add bounds checking for path construction in splash screen loading Fixes crash: PRIV_INSTRUCTION exception at 0x0005028E Files modified: - GeneralsMD/Code/GameEngine/Source/GameClient/InGameUI.cpp (line 7200) - GeneralsMD/Code/Main/WinMain.cpp (lines 316, 858) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…on thread safety, async lambda captures, and screenshot thread races - Fix Issue #5: Replace 'delete this' pattern with thread-safe deferred deletion pool Prevents use-after-free when ConnectionSignaling::Release() called from Steam async callbacks Added CleanupPendingConnSignalingDeletions() called from OnSteamNetConnectionStatusChanged - Fix Issue #6: Lambda capture race in GetAndParseServiceConfig Changed from implicit 'this' capture to explicit GetInstance() calls inside lambda Added null-check for manager during async HTTP callback execution - Fix Issue #3: Screenshot thread registration TOCTOU race Protected GetInstance() call with mutex before thread storage Graceful handling when manager destroyed during shutdown All 7 critical vulnerabilities now fixed: 1. Singleton thread safety (Fix #1) - Already applied in previous commit 2. WebSocket buffer overflow (Fix #2) - Already applied in previous commit 3. Screenshot thread race (Fix #3) - NEWLY FIXED 4. rlen validation (Fix #4) - Already applied in previous commit 5. Delete this pattern (Fix #5) - NEWLY FIXED 6. Lambda capture race (Fix #6) - NEWLY FIXED 7. Async callback safety - NEWLY FIXED Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
- Add #include <mutex> to OnlineServices_Init.cpp for static m_singletonMutex definition - Add PlayerConnection::IsValid() method to NetworkMesh.h for connection state validation Returns true if connection is in a valid state (not NOT_CONNECTED, CONNECTION_FAILED, or CONNECTION_DISCONNECTED) Fixes linker error on m_singletonMutex and compilation error on PlayerConnection::IsValid() Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.