Skip to content

fix(Model): check new component uuid wrt other actual uuids in a model#1267

Merged
BotellaA merged 6 commits into
nextfrom
fix/check-component-uuid
Jun 5, 2026
Merged

fix(Model): check new component uuid wrt other actual uuids in a model#1267
BotellaA merged 6 commits into
nextfrom
fix/check-component-uuid

Conversation

@panquez
Copy link
Copy Markdown
Member

@panquez panquez commented May 7, 2026

No description provided.

@panquez panquez requested a review from BotellaA May 7, 2026 05:48
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 7, 2026

Cpp-Linter Report ⚠️

Some files did not pass the configured checks!

clang-tidy (v20.1.8) reports: 2 concern(s)
  • include/geode/model/mixin/core/detail/components_storage.hpp:153:39: warning: [cppcoreguidelines-avoid-magic-numbers]

    36 is a magic number; consider replacing it with a named constant

      153 |                 if( filename.size() > 36 )
          |                                       ^
  • include/geode/model/mixin/core/detail/components_storage.hpp:155:68: warning: [cppcoreguidelines-avoid-magic-numbers]

    36 is a magic number; consider replacing it with a named constant

      155 |                     auto uuid = filename.substr( filename.size() - 36 );
          |                                                                    ^

Have any feedback or feature suggestions? Share it here.

Comment thread include/geode/model/mixin/core/detail/components_storage.hpp Outdated
Comment thread include/geode/model/mixin/core/detail/components_storage.hpp
@BotellaA BotellaA merged commit 44f8f44 into next Jun 5, 2026
20 checks passed
@BotellaA BotellaA deleted the fix/check-component-uuid branch June 5, 2026 14:12
@BotellaA
Copy link
Copy Markdown
Member

BotellaA commented Jun 5, 2026

🎉 This PR is included in version 17.2.0-rc.3 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@BotellaA
Copy link
Copy Markdown
Member

BotellaA commented Jun 8, 2026

🎉 This PR is included in version 17.2.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants