Skip to content

fix(FailedMedialBallTest) : store AABB trees as unique_ptr in ray_tra…#1285

Merged
BotellaA merged 4 commits into
nextfrom
fix/store_AABB_trees_as_unique_ptr
Jun 8, 2026
Merged

fix(FailedMedialBallTest) : store AABB trees as unique_ptr in ray_tra…#1285
BotellaA merged 4 commits into
nextfrom
fix/store_AABB_trees_as_unique_ptr

Conversation

@MoulardM

@MoulardM MoulardM commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

…cing

@MoulardM MoulardM requested a review from BotellaA June 8, 2026 12:01
Comment thread src/geode/model/helpers/ray_tracing.cpp Outdated
{
absl::ReaderMutexLock read_lock{ mutex_ };
if( aabb_trees_.contains( surface.id() ) )
auto it = aabb_trees_.find( surface.id() );

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
auto it = aabb_trees_.find( surface.id() );
const auto it = aabb_trees_.find( surface.id() );

Comment thread src/geode/model/helpers/ray_tracing.cpp Outdated
return aabb_trees_
.emplace( surface.id(), create_aabb_tree( surface.mesh() ) )
.first->second;
auto [it, inserted] = aabb_trees_.emplace(

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
auto [it, inserted] = aabb_trees_.emplace(
const auto [it, inserted] = aabb_trees_.emplace(

@github-actions

github-actions Bot commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

Cpp-Linter Report ⚠️

Some files did not pass the configured checks!

clang-tidy (v20.1.8) reports: 4 concern(s)
  • src/geode/model/helpers/ray_tracing.cpp:46:64: warning: [readability-identifier-naming]

    invalid case style for function 'directions_2D'

       46 |     const std::array< geode::Vector2D, NUMBER_2D_DIRECTIONS >& directions_2D()
          |                                                                ^~~~~~~~~~~~~
          |                                                                directions_2_d
  • src/geode/model/helpers/ray_tracing.cpp:64:64: warning: [readability-identifier-naming]

    invalid case style for function 'directions_3D'

       64 |     const std::array< geode::Vector3D, NUMBER_3D_DIRECTIONS >& directions_3D()
          |                                                                ^~~~~~~~~~~~~
          |                                                                directions_3_d
  • src/geode/model/helpers/ray_tracing.cpp:305:28: warning: [readability-identifier-length]

    variable name 'it' is too short, expected at least 3 characters

      305 |                 const auto it = aabb_trees_.find( surface.id() );
          |                            ^
  • src/geode/model/helpers/ray_tracing.cpp:311:25: warning: [readability-identifier-length]

    variable name 'it' is too short, expected at least 3 characters

      311 |             const auto [it, inserted] = aabb_trees_.emplace(
          |                         ^

Have any feedback or feature suggestions? Share it here.

@BotellaA BotellaA merged commit 9f9d733 into next Jun 8, 2026
20 checks passed
@BotellaA BotellaA deleted the fix/store_AABB_trees_as_unique_ptr branch June 8, 2026 15:17
@BotellaA

BotellaA commented Jun 8, 2026

Copy link
Copy Markdown
Member

🎉 This PR is included in version 17.2.1-rc.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants