Skip to content

Add milestone for Kubeflow Community repo#2473

Open
varodrig wants to merge 1 commit intoGoogleCloudPlatform:masterfrom
varodrig:grad2
Open

Add milestone for Kubeflow Community repo#2473
varodrig wants to merge 1 commit intoGoogleCloudPlatform:masterfrom
varodrig:grad2

Conversation

@varodrig
Copy link

@varodrig varodrig commented Apr 28, 2025

This adds v1.0 milestone for Kubeflow Community repository.

For now, we will use the Kubeflow Outreach Committee to apply milestone.

cc @franciscojavierarceo @andreyvelich

@google-oss-prow
Copy link
Contributor

Hi @varodrig. Thanks for your PR.

I'm waiting for a GoogleCloudPlatform member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@varodrig varodrig changed the title new milestone Add milestone for Kubeflow Community repo Apr 28, 2025
@varodrig varodrig marked this pull request as ready for review April 28, 2025 04:04
@google-oss-prow google-oss-prow bot requested a review from chases2 April 28, 2025 04:04
Copy link
Contributor

@andreyvelich andreyvelich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/hold for review

Copy link
Member

@cjwagner cjwagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
Note however, that this doesn't actually create a v1.0 milestone for the repo.

@google-oss-prow
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cjwagner, varodrig

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@andreyvelich
Copy link
Contributor

@cjwagner We are still discussing with the community whether we want to use milestone for the CNCF Graduation tasks or labels are sufficient: https://github.com/kubeflow/community/issues?q=is%3Aissue%20state%3Aopen%20label%3Aarea%2Fcncf-graduation

@varodrig
Copy link
Author

varodrig commented May 3, 2025

/hold for review

since it's approved @andreyvelich what's left to remove the hold.

@andreyvelich
Copy link
Contributor

@varodrig Please can we discuss during tomorrow's Kubeflow Graduation Call whether we need the Milestone or the specific label is sufficient: https://github.com/kubeflow/community/issues?q=is%3Aissue%20state%3Aopen%20label%3Aarea%2Fcncf-graduation ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants