New node: Decimate

[Keavon]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a new decimate node, which provides a powerful tool for simplifying vector graphics. It intelligently reduces the number of points in a path using the Ramer-Douglas-Peucker algorithm, maintaining the visual integrity of the shape within a user-defined tolerance. This enhancement improves efficiency and reduces complexity for vector operations.

Highlights

• New Decimate Node: Added a new decimate node to simplify vector paths by removing redundant points.
• Ramer-Douglas-Peucker Algorithm: Implemented the Ramer-Douglas-Peucker (RDP) algorithm as the core logic for path simplification.
• Curve Sampling: Included functionality to sample Bezier curves into polylines before applying the RDP algorithm, ensuring accurate simplification of curved segments.

Changelog

• node-graph/nodes/vector/src/vector_nodes.rs
  • Added the decimate node, which simplifies vector paths using the Ramer-Douglas-Peucker algorithm.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces a decimate node, which simplifies vector paths using the Ramer-Douglas-Peucker (RDP) algorithm. The implementation correctly handles path transformations and samples curves into polylines before simplification. However, the core RDP algorithm is implemented recursively, which poses a risk of stack overflow for paths with a large number of points. I've suggested switching to an iterative implementation to improve robustness.

[cubic-dev-ai]

1 issue found across 1 file

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="node-graph/nodes/vector/src/vector_nodes.rs">

<violation number="1" location="node-graph/nodes/vector/src/vector_nodes.rs:1396">
P2: Closed paths get a duplicate start/end point, causing a redundant zero-length segment. When the bezpath is closed, the last segment's `end()` equals the first point, so `points` ends with a duplicate of `points[0]`. Since RDP always preserves the first and last point, the reconstruction emits `line_to(start)` followed by `close_path()`, producing a degenerate zero-length line segment.

Remove the duplicate closing point before running RDP on closed paths.</violation>
</file>

_{Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.}