Skip to content

Canvas Label Positioning in Node Graph is not at desired location.#3852

Open
Annonnymmousss wants to merge 1 commit intoGraphiteEditor:masterfrom
Annonnymmousss:fix/canvas_label_position
Open

Canvas Label Positioning in Node Graph is not at desired location.#3852
Annonnymmousss wants to merge 1 commit intoGraphiteEditor:masterfrom
Annonnymmousss:fix/canvas_label_position

Conversation

@Annonnymmousss
Copy link
Contributor

@Annonnymmousss Annonnymmousss commented Mar 3, 2026

Regression caused by commit 5b472a6

Before :

Screen.Recording.2026-03-03.at.5.52.20.PM.mov

After :

Screen.Recording.2026-03-03.at.5.44.07.PM.mov

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves a regression affecting the accurate positioning of canvas labels within the node graph. By ensuring the node graph's width is correctly updated upon opening, this change restores the intended display behavior for labels, improving the user experience in the editor.

Highlights

  • Node Graph Label Positioning Fix: Addressed a regression that caused canvas labels in the node graph to be positioned incorrectly. The fix ensures the node graph's width is explicitly updated when it is opened, resolving the display issue.
Changelog
  • editor/src/messages/portfolio/document/document_message_handler.rs
    • Added a message to update the node graph width when the node graph is opened.
Activity
  • No review comments or activity have been recorded yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request addresses a regression where canvas labels in the node graph were incorrectly positioned. The fix involves dispatching a NodeGraphMessage::UpdateNodeGraphWidth message when the node graph overlay is opened. This ensures that the layout system has the correct viewport width, which is essential for accurate positioning of elements within the node graph. The change is a targeted one-line fix that appears to correctly resolve the described issue.

Copy link

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

@Keavon
Copy link
Member

Keavon commented Mar 3, 2026

!build (Run ID 22639031244)

@github-actions
Copy link

github-actions bot commented Mar 3, 2026

📦 Build Complete for 27ad279
https://9f5e79f4.graphite.pages.dev

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants