Canvas Label Positioning in Node Graph is not at desired location.#3852
Canvas Label Positioning in Node Graph is not at desired location.#3852Annonnymmousss wants to merge 1 commit intoGraphiteEditor:masterfrom
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request resolves a regression affecting the accurate positioning of canvas labels within the node graph. By ensuring the node graph's width is correctly updated upon opening, this change restores the intended display behavior for labels, improving the user experience in the editor. Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request addresses a regression where canvas labels in the node graph were incorrectly positioned. The fix involves dispatching a NodeGraphMessage::UpdateNodeGraphWidth message when the node graph overlay is opened. This ensures that the layout system has the correct viewport width, which is essential for accurate positioning of elements within the node graph. The change is a targeted one-line fix that appears to correctly resolve the described issue.
|
!build (Run ID 22639031244) |
|
Regression caused by commit 5b472a6
Before :
Screen.Recording.2026-03-03.at.5.52.20.PM.mov
After :
Screen.Recording.2026-03-03.at.5.44.07.PM.mov