fix: unlink all OIDC providers when user updates email address#3307
Merged
Salazareo merged 1 commit intoJun 25, 2026
Merged
Conversation
Salazareo
approved these changes
Jun 25, 2026
Salazareo
left a comment
Member
There was a problem hiding this comment.
LGTM! Thanks for the contribution!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey folks,
took a quick peek under the hood to patch that SSO backdoor we talked about. Since updating the primary email was leaving the old OIDC credentials hardwired to the user record i wired up a quick manual override on the database layer to cleanly sever the connection.
I've added a call to decouple all OIDC providers upon an email update
await this.stores.oidc.unlinkAllByUserId(user.id);And implemented the corresponding query in the store to purge those old bindings from the table
This properly cuts the cord on those old SSO keys and locks them out. Let me know if you need any calibration on this patch