Prevent transforming of async expressions#363
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current debug instrumentation machinery has no understanding of the new
AsyncExpressionandAsyncEnumerableExpressionand hard-fails trying to transform them.This PR prevents the existing mechanism descending into those expressions. It prevents crashes when instrumentation is enabled, but it also leaves async expressions un-debuggable — for now. The debug instrumentation of async expressions deserves it own PR.
When used in IronPython, it will "resolve" IronLanguages/ironpython3#2057. "Resolve" in quotes because the crash is gone, but instrumentation is still not implemented (this is already true for .NET-based coroutines, though — i.e. no crash, no instrumentation).