Revised and left comments on "A walk in the sun."#11
Open
aprilyou wants to merge 1 commit into
Open
Conversation
Just comments on things that were a bit unclear/vague and grammar mistakes. You have a distinct style of writing, and I think that gives a nice color to your narrator. :)
Owner
|
First, thanks a lot for all the comments, Problem is, there are some errors (Travis complained, see above) and if I accepted it I would have to work through the comments to get to the real corrections. So I guess it's better if we use this to discuss and then I'll effectively pull from your repo. |
| And you want to hear mine? | ||
| OK, Duke, I owe you. So here it goes. | ||
|
|
||
| #####The transition between this first paragraph and the second one is a bit rough. The character talks to a person named Duke and then it suddenly goes to Gummy. While it's established that there are multiple people the narrator is talking to, it's a bit confusing as there is a jarring jump. |
Owner
There was a problem hiding this comment.
Maybe referring to Duke and Gummy in the line above would help?
|
@aprilyou : if you change the #### to bold that should make the tests pass (tips here: https://guides.github.com/features/mastering-markdown/) |
Collaborator
|
Tests actually complain about words it does not recognize, but the thing is
that I would have to edit that comments out anyway. That's why it's better
to make comments directly as issues. Easier to talk about them, too..
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just comments on things that were a bit unclear/vague and grammar mistakes. You have a distinct style of writing, and I think that gives a nice color to your narrator. :)