Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #108 +/- ##
=======================================
Coverage 78.27% 78.27%
=======================================
Files 34 34
Lines 925 925
=======================================
Hits 724 724
Misses 201 201 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| # To reduce the number of CI jobs, we test Linux 64-bit against all Julia versions (see above), | ||
| # but for other platforms: |
There was a problem hiding this comment.
| # To reduce the number of CI jobs, we test Linux 64-bit against all Julia versions (see above), | |
| # but for other platforms: | |
| # We test Linux 64-bit against all Julia versions (see above), | |
| # but for other platforms we test less (see below). Thus reducing number of CI jobs |
oxinabox
left a comment
There was a problem hiding this comment.
I am not sure it's worth having CI on anything except linux if it doesn't test all versions.
Because a change that only effects one version could be made in any PR.
|
Should I just remove Windows and macOS CI, in that case? |
Yes, i think so |
|
I've removed all of the Windows and macOS CI jobs. What should we do about 32-bit Linux? |
Let's remove that too, and we can add it back in if someone finds that we have ever broken something on 32 bit |
Before this PR, we have 64 CI jobs, which is a lot.
This PR reduces the number of CI jobs:
After this PR, we have 23 CI jobs.