Replace legacy Youtube-dl with currently maintained yt-dlp#86
Open
Aida-Enna wants to merge 1 commit intoKagami:masterfrom
Open
Replace legacy Youtube-dl with currently maintained yt-dlp#86Aida-Enna wants to merge 1 commit intoKagami:masterfrom
Aida-Enna wants to merge 1 commit intoKagami:masterfrom
Conversation
|
This. YoutubeDL has still not updated it's releases, even though it works now, and yt-dlp is more frequently updated in general. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replacing the included youtube-dl.exe with a renamed yt-dlp.exe made everything work as expected again and download fast. Based on this, this PR should fix the issue across all platforms with minimal changes, mostly comsetic (youtube-dl -> yt-dlp).
I modified the package stuff to include these as well, although I'm not sure why the python script is saved as a .zip. I also checked and there is a brew package for yt-dlp, so I swapped that as well.
Should fix #67 and #61, although I don't have a build environment set up for this to test it.