Skip to content

fix(types): mark all slots as optional#2756

Merged
Justineo merged 1 commit intomainfrom
fix/define-slots
May 16, 2025
Merged

fix(types): mark all slots as optional#2756
Justineo merged 1 commit intomainfrom
fix/define-slots

Conversation

@Justineo
Copy link
Member

@Justineo Justineo commented May 15, 2025

Summary

KM-1279

Fixes the type errors mentioned at #2753.

@Justineo Justineo requested a review from a team as a code owner May 15, 2025 03:46
@netlify
Copy link

netlify bot commented May 15, 2025

Deploy Preview for kongponents-sandbox ready!

Name Link
🔨 Latest commit f609c44
🔍 Latest deploy log https://app.netlify.com/projects/kongponents-sandbox/deploys/6825637f470aac000894c19f
😎 Deploy Preview https://deploy-preview-2756--kongponents-sandbox.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented May 15, 2025

Deploy Preview for kongponents ready!

Name Link
🔨 Latest commit f609c44
🔍 Latest deploy log https://app.netlify.com/projects/kongponents/deploys/6825637fb0a7bf0008a32743
😎 Deploy Preview https://deploy-preview-2756--kongponents.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@johncowen
Copy link
Contributor

FYI @Justineo , I just tried this here to verify and this fixes the immediate issue in our app 🎉 . I'll keep an eye on this going in, thanks again! 👍

@johncowen
Copy link
Contributor

johncowen commented May 16, 2025

Hey 👋 just a small nit here as I realized this is marked to close #2753

Would be great if we could leave that one (#2753) open until the test .ts files are being typechecked?

P.S. Just in case/FYI I wasn't planning on finishing up #2752 myself/personally it was just to give a reproduction of the issue.

@Justineo Justineo merged commit 1b47485 into main May 16, 2025
11 checks passed
@Justineo Justineo deleted the fix/define-slots branch May 16, 2025 15:12
kongponents-bot pushed a commit that referenced this pull request May 16, 2025
## [9.31.9](v9.31.8...v9.31.9) (2025-05-16)

### Bug Fixes

* **types:** mark all slots as optional ([#2756](#2756)) ([1b47485](1b47485))
@kongponents-bot
Copy link
Collaborator

🎉 This PR is included in version 9.31.9 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants