fix(selectlist): host browser icons locally instead of hotlinking Wikimedia#149
Open
Dotify71 wants to merge 1 commit into
Open
fix(selectlist): host browser icons locally instead of hotlinking Wikimedia#149Dotify71 wants to merge 1 commit into
Dotify71 wants to merge 1 commit into
Conversation
…imedia The Dribbble filter demo used external Wikimedia thumbnail URLs for browser icons (Brave, Edge, Chrome, Firefox, Safari, Opera). These URLs now return HTTP 400/404 due to Wikimedia's CDN policy on arbitrary thumbnail dimensions, causing all icons to silently fail to load. This commit downloads the original SVG/PNG source files from Wikimedia Commons and stores them under selectlist/images/. The CSS background-image declarations are updated to reference these local paths, making the demo self-contained and reliable. Fixes MicrosoftEdge#148
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #148
The Dribbble filter demo in
/selectlist/index.htmluses CSSbackground-imageto display icons for six browsers (Brave, Edge, Chrome, Firefox, Safari, Opera). These images were hotlinked directly from Wikimedia Commons thumbnail URLs, such as:These URLs now return
HTTP 400 Bad RequestorHTTP 404 Not Foundbecause Wikimedia's CDN no longer serves thumbnails at arbitrary pixel dimensions when requested externally. As a result, all six browser icons fail to load silently in the demo.Changes
selectlist/images/directorybackground-imageCSS declarations inindex.htmlto use local relative pathsBefore / After
Before: Icons are broken (empty boxes) in the Browser filter dropdown
After: All browser icons render correctly from locally hosted files
Testing
Open
selectlist/index.htmlin a browser (or the live GitHub Pages URL once merged) and check the Dribbble filter demo — the Browser dropdown should show all six icons correctly.