fix: isolate AI review secrets from pull request code#193
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MINIMAX_API_KEYand Bash access from the secret-bearing review stepRoot cause
The review job checked out the PR head, injected
MINIMAX_API_KEY, allowed Bash, and instructed the agent to run the PR's tests. A same-repository branch could therefore execute attacker-controlled test code in the secret-bearing process.Impact
PR code still receives normal automated checks, but it no longer executes in the job that holds the review provider credential and a pull-request write token. Live MiniMax smoke tests are intentionally removed from this untrusted workflow.
Validation
bun test— 376 passedbun run typecheckbun run lint— 0 errorsMINIMAX_API_KEYnor Bash in the reviewer tool allowlistgit diff --check