[Feat] Add dram pool buffer manager#1116
Merged
Wwwzff merged 1 commit intoJul 20, 2026
Merged
Conversation
Infinite666
requested review from
Wwwzff,
mag1c-h,
nrj868 and
ygwpz
as code owners
July 17, 2026 03:43
Infinite666
force-pushed
the
feature_26h1_meta
branch
9 times, most recently
from
July 20, 2026 07:51
9e559b1 to
128ac95
Compare
Infinite666
force-pushed
the
feature_26h1_meta
branch
from
July 20, 2026 09:07
128ac95 to
47db036
Compare
Infinite666
force-pushed
the
feature_26h1_meta
branch
from
July 20, 2026 09:40
47db036 to
22d980a
Compare
Wwwzff
approved these changes
Jul 20, 2026
Wwwzff
merged commit Jul 20, 2026
6d92474
into
ModelEngine-Group:feature_26h1
15 of 16 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
BufferManagerof dram pool, it contains multipleBufferPoolfor different buffer sizes. It helps to chooseBufferPoolbased on the given size.BufferManagerin metadata management.TODO: Adaption for SIMU env to run gtest in pipeline.
Modifications
buffer.h: CommonBufferstruct forBufferManagerandEntry.buffer_manager.cc/.h: ImplementBufferManagerclass.eviction_policy.h: Modify the return value ofGetEvictionResultsfromBlockIdtoEntryfor the later free of buffer slot.metadata.cc/.h: Move the gc thread fromMetadataManagertoDramPoolServer, so that all the background threads are maintained byDramPoolServer.drampool_server.cpp/.h: ReplacedBufferPoolListbyBufferManager.Test