Skip to content

[Feat] Add dram pool buffer manager#1116

Merged
Wwwzff merged 1 commit into
ModelEngine-Group:feature_26h1from
Infinite666:feature_26h1_meta
Jul 20, 2026
Merged

[Feat] Add dram pool buffer manager#1116
Wwwzff merged 1 commit into
ModelEngine-Group:feature_26h1from
Infinite666:feature_26h1_meta

Conversation

@Infinite666

@Infinite666 Infinite666 commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

Purpose

  1. Implement BufferManager of dram pool, it contains multiple BufferPool for different buffer sizes. It helps to choose BufferPool based on the given size.
  2. Complete the TODOs relied on BufferManager in metadata management.
    TODO: Adaption for SIMU env to run gtest in pipeline.

Modifications

  1. buffer.h: Common Buffer struct for BufferManager and Entry.
  2. buffer_manager.cc/.h: Implement BufferManager class.
  3. eviction_policy.h: Modify the return value of GetEvictionResults from BlockId to Entry for the later free of buffer slot.
  4. metadata.cc/.h: Move the gc thread from MetadataManager to DramPoolServer, so that all the background threads are maintained by DramPoolServer.
  5. drampool_server.cpp/.h: Replaced BufferPoolList by BufferManager.

Test

[==========] Running 71 tests from 5 test suites.
[----------] Global test environment set-up.
[----------] 19 tests from UCLruEvictionPolicyTest (5 ms total)
[----------] 22 tests from UCShardMetadataTest (0 ms total)
[----------] 4 tests from UCMetadataManagerTest (6 ms total)
[----------] 14 tests from UCPosEvictionPolicyTest (0 ms total)
[----------] 12 tests from UCTtlEvictionPolicyTest (0 ms total)

[----------] Global test environment tear-down
[==========] 71 tests from 5 test suites ran. (4660 ms total)
[  PASSED  ] 71 tests.

@Infinite666
Infinite666 force-pushed the feature_26h1_meta branch 9 times, most recently from 9e559b1 to 128ac95 Compare July 20, 2026 07:51
nrj868
nrj868 previously approved these changes Jul 20, 2026

@nrj868 nrj868 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Wwwzff
Wwwzff merged commit 6d92474 into ModelEngine-Group:feature_26h1 Jul 20, 2026
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants