fix: exclude binary and large files from LLM analysis#307
Open
Makia9879 wants to merge 1 commit into
Open
Conversation
Signed-off-by: Makia98 <makia98@foxmail.com>
Makia9879
force-pushed
the
feat/filter-llm-input-files
branch
from
July 24, 2026 10:26
93b68fe to
41b5110
Compare
Makia9879
marked this pull request as ready for review
July 24, 2026 10:27
rng1995
requested changes
Jul 24, 2026
rng1995
left a comment
Collaborator
There was a problem hiding this comment.
[Automated SkillSpector Review]
Requesting changes because the filter uses attacker-controlled filename suffixes as a binary predicate and does not implement the PR title's large-file exclusion. A text payload named .png is removed from semantic analysis, while extensionless binaries and arbitrarily large text files are still batched. Please base skipping on inspected content or trusted metadata, define and test the size rule, and preserve scan-completeness accounting for skipped files.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Skip image, audio, and video files when creating LLM analysis batches.
Changes
LLMAnalyzerBase.get_batches().Verification
1393 passed12 skipped6 xfailed