Skip to content

fix(rest-api): preserve addressless machine interfaces#4137

Draft
kfelternv wants to merge 1 commit into
NVIDIA:mainfrom
kfelternv:agent/nvbug-6503989-addressless-interfaces
Draft

fix(rest-api): preserve addressless machine interfaces#4137
kfelternv wants to merge 1 commit into
NVIDIA:mainfrom
kfelternv:agent/nvbug-6503989-addressless-interfaces

Conversation

@kfelternv

Copy link
Copy Markdown
Contributor

REST machine inventory currently passes Core's empty interface address list through as nil, causing the non-null database write to fail and the interface to be omitted while inventory processing continues. This change maps empty address lists to an empty database array and adds regression coverage showing an addressless interface remains in inventory.

Related issues

Type of Change

  • Add - New feature or capability
  • Change - Changes in existing functionality
  • Fix - Bug fixes
  • Remove - Removed features or deprecated functionality
  • Internal - Internal changes (refactoring, tests, docs, etc.)

Breaking Changes

  • This PR contains breaking changes

Testing

  • Unit tests added/updated
  • Integration tests added/updated
  • Manual testing performed
  • No testing required (docs, internal refactor, etc.)

Additional Notes

Signed-off-by: Kyle Felter <kfelter@nvidia.com>
@copy-pr-bot

copy-pr-bot Bot commented Jul 24, 2026

Copy link
Copy Markdown

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@coderabbitai

coderabbitai Bot commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 70e63d8d-b2be-40c3-9eba-51c060a2a5c1

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant