refactor: unify core execution flow and rename Manage methods to Run for consistency#24
Merged
1 commit merged intoMay 23, 2025
Merged
refactor: unify core execution flow and rename Manage methods to Run for consistency#241 commit merged into
1 commit merged into
Conversation
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request refactors the core dispatch mechanism and unifies the lifecycle management of different modes (
server,client,master) by introducing a commonRuninterface. It also includes minor structural adjustments to improve code maintainability and consistency.Refactoring and Unification of Lifecycle Management:
coreDispatchfunction's mode-specific methods (runServer,runClient,runMaster) with a unified approach using aRuninterface. TheRunmethod is now implemented forServer,Client, andMasterclasses, consolidating lifecycle management. (cmd/nodepass/core.go, cmd/nodepass/core.goL14-R31)Managemethod toRuninClient,Server, andMasterto align with the new unified interface. (internal/client.go, [1];internal/server.go, [2];internal/master.go, [3]Structural and Functional Enhancements:
tunnelListenerfield to theCommonstruct for managing tunnel listeners, and updated thestopmethod to ensure proper closure of this resource. (internal/common.go, [1] [2]tunnelListenerfield from theServerstruct, as it is now managed centrally in theCommonstruct. (internal/server.go, internal/server.goL22)