Skip to content

feat(ui): Changelog browser pilot on the shared design system (U5 B1)#430

Open
OBenner wants to merge 1 commit into
developfrom
claude/ui-b1-pilot
Open

feat(ui): Changelog browser pilot on the shared design system (U5 B1)#430
OBenner wants to merge 1 commit into
developfrom
claude/ui-b1-pilot

Conversation

@OBenner

@OBenner OBenner commented Jul 17, 2026

Copy link
Copy Markdown
Owner

Summary

First screen of the B1 "Code & review" batch (U5), ported from desktop-changelog.html. All five B1 mockups already exist, so the batch goes straight to implementation; Changelog pilots the playbook.

libs/ui (shared design system)

  • ChangelogView: timeline rail grouped by year (semver-type dots, single selection with aria-current, focus rings) + scrollable release feed (mono version, release name, type badge, typed section icons + / ! / ⚠ / d, sha chips) + optional right meta rail on the shared UiMetaSection card family; loading/error/empty states.
  • New shared types: UiRelease / UiReleaseSection / UiReleaseEntry / UiReleaseType / UiReleaseSectionKind. UiRelease.id is required — real CHANGELOG files repeat versions across format blocks.

Electron

  • Pure changelog-releases parser: keep-a-changelog plus the generator's loose/name-suffixed headings; ISO dates formatted in UTC (labels don't shift west of UTC); inline markdown stripped; position-qualified unique ids under duplicate versions.
  • ChangelogPilotView over the existing changelog:readExisting IPC, mounted as "Changelog (new UI)" beside the legacy generator wizard (which stays untouched).

i18n

  • New changelog namespace (en+fr), navigation:items.changelogNext keys.
  • Fix: registers the previously-unregistered kanban namespace — the shipped Kanban pilot was rendering raw kanban:pilot.* keys in live Electron.

Adversarial review (18 agents, find → verify)

6 confirmed defects were fixed during the slice, several verified by executing the parser against this repo's real CHANGELOG.md:

  1. Timezone-shifted date labels + TZ-flaky test (off-by-one west of UTC, Jan 1 filed under the previous year) → UTC formatting, regression pinned under TZ=America/New_York.
  2. Duplicate versions (2.7.5, 2.6.0 appear twice in the real file) broke React keys, the scroll ref map, and produced two aria-current rows → required id, position-qualified.
  3. "Jun 8 (planned)" Date-parsed to year 2001 (RFC-2822 comment quirk) → strict-ISO gate.
  4. Heading regex ate the closing paren of annotations → suffix parsed separately.
  5. Generator name-suffixes (## 2.7.5 - Security & Platform Improvements) rendered as dates → non-ISO suffixes become release names.
  6. Meta-card CSS drift vs the mockup/TaskDetail family (h3 weight/size/margin, kv gap) → aligned.

3 findings refuted with evidence (dot color-only signaling — text badge exists in-feed; ungated smooth scroll — house style in 5 merged files; JSX structural clones — no enforced rule fires).

Verification

  • 15/15 parser tests, run in UTC and TZ=America/New_York; smoke-parsed the repo's real 114KB CHANGELOG.md (unique ids, sane year groups).
  • libs/ui tsc + Electron typecheck (CI-style hoisted node_modules) clean.
  • Storybook rebuilt; ReleaseHistory story verified in light+dark, rail selection exercised in DOM (single --on, single aria-current, aligned card typography).

Next in B1

GitHub PRs / GitHub Issues / Patterns / Context screens on the same playbook.

🤖 Generated with Claude Code

First screen of the B1 "Code & review" batch, ported from
desktop-changelog.html:

- libs/ui: new ChangelogView screen — timeline rail grouped by year
  (semver-type dots, position-qualified selection, aria-current),
  release feed (version/name head, type badge, typed section icons,
  sha chips), optional right meta rail on the shared UiMetaSection
  card family; loading/error/empty states. New shared types:
  UiRelease/UiReleaseSection/UiReleaseEntry/UiReleaseType/
  UiReleaseSectionKind (UiRelease.id is required — real CHANGELOG
  files repeat versions across format blocks).
- Electron: pure changelog-releases parser (keep-a-changelog + the
  generator's loose/name-suffixed headings; ISO dates formatted in
  UTC so labels don't shift west of UTC; inline markdown stripped;
  ids unique under duplicate versions) + ChangelogPilotView over the
  existing changelog:readExisting IPC, mounted as "Changelog (new
  UI)" beside the legacy generator wizard.
- i18n: new changelog namespace (en+fr), navigation.changelogNext
  keys, and registration of the previously-unregistered kanban
  namespace so the Kanban pilot stops rendering raw keys.

Adversarial review workflow (18 agents) confirmed 6 defects during
the slice — timezone-shifted dates + TZ-flaky test, duplicate-version
React keys/ref-map collisions, "Jun 8" Date-parsing into a bogus 2001
year group, paren-eating heading regex, generator name-suffixes
rendered as dates, meta-card CSS drift — all fixed and pinned by
tests (15 passing, verified under TZ=America/New_York and against
this repo's real CHANGELOG.md).

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@cursor

cursor Bot commented Jul 17, 2026

Copy link
Copy Markdown

Bugbot is not enabled for your account, so this pull request was not reviewed.

Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs.

@coderabbitai

coderabbitai Bot commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

@OBenner, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 38 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: 94d937e4-0f35-4929-aab0-e42993521aff

📥 Commits

Reviewing files that changed from the base of the PR and between 78775d5 and 3dc357d.

📒 Files selected for processing (15)
  • apps/frontend/src/renderer/App.tsx
  • apps/frontend/src/renderer/__tests__/changelog-releases.test.ts
  • apps/frontend/src/renderer/components/ChangelogPilotView.tsx
  • apps/frontend/src/renderer/components/Sidebar.tsx
  • apps/frontend/src/renderer/lib/changelog-releases.ts
  • apps/frontend/src/shared/i18n/index.ts
  • apps/frontend/src/shared/i18n/locales/en/changelog.json
  • apps/frontend/src/shared/i18n/locales/en/navigation.json
  • apps/frontend/src/shared/i18n/locales/fr/changelog.json
  • apps/frontend/src/shared/i18n/locales/fr/navigation.json
  • libs/ui/src/client/types.ts
  • libs/ui/src/index.ts
  • libs/ui/src/screens/ChangelogView.css
  • libs/ui/src/screens/ChangelogView.stories.tsx
  • libs/ui/src/screens/ChangelogView.tsx
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch claude/ui-b1-pilot

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@sonarqubecloud

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant