feat(robot-server, api): Serpent serialization for all layers and coverage enforcement testing#21396
Draft
CaseyBatten wants to merge 24 commits into
Draft
feat(robot-server, api): Serpent serialization for all layers and coverage enforcement testing#21396CaseyBatten wants to merge 24 commits into
CaseyBatten wants to merge 24 commits into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## edge #21396 +/- ##
==========================================
+ Coverage 21.64% 21.67% +0.02%
==========================================
Files 3896 3903 +7
Lines 326958 327033 +75
Branches 58072 58124 +52
==========================================
+ Hits 70783 70876 +93
+ Misses 253212 253189 -23
- Partials 2963 2968 +5
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
…or and auto wrapping
…serialize into strings of integers
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Covers EXEC-2435, EXEC-2465, and EXEC-2609
THIS IS EXTREMELY DRAFT EARLY VERSION -- EXPECT IT TO BE VERY BROKEN, IT WILL BE BETTER SOON I PROMISE :)
NOTE TO REVIEWERS:
I used an LLM to generate the majority of the PARAMETERS_MOCK_TABLE data given the sheer amount of parameters that were found by scraping our interface layer for our three processes. This generated table was based off a small sample size table I hand built. I have combed through the mock and dummy data introduced throughout the table, and to my eyes it seems correct but PLEASE keep a keen eye on the data and how it's being tested against elsewhere. I built a substantial portion of the testing suite around this large data set, so it's important that we be scrutinous of it!
This PR adds in a large unit test suite that spins up each of our Pyro layers in a thread and does interface scraping and testing against each of them. It also adds in serialization for our missing libraries.
- OT3API coverage tests: Methods test, attributes test
- ROBOT-SERVER coverage tests: Methods test, attributes test
- DIRECTED-RUN coverage tests: Methods test, attributes test
Test Plan and Hands on Testing
Changelog
test_serialization_enforcement.pyconvert_result_to_dict_of_proxiesto give us coverage for things that are dictionaries of proxiesTBD
Review requests
TBD
Risk assessment
Low - this serializes the rest of our stuff and will make sure we future proof extending our libraries