(e2e-testing): Make fewer GitHub actions when setting up e2e-testing#21547
Open
alexjoel42 wants to merge 4 commits into
Open
(e2e-testing): Make fewer GitHub actions when setting up e2e-testing#21547alexjoel42 wants to merge 4 commits into
alexjoel42 wants to merge 4 commits into
Conversation
We formerly included the full setup-js but now I'm going to try and have it take a shorter set up time by only using what's necessary for e2e-testing
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## edge #21547 +/- ##
=======================================
Coverage 21.12% 21.12%
=======================================
Files 3911 3911
Lines 327221 327221
Branches 58192 58189 -3
=======================================
Hits 69140 69140
Misses 255112 255112
Partials 2969 2969
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
y3rsh
requested changes
May 20, 2026
Member
y3rsh
left a comment
y3rsh
left a comment
There was a problem hiding this comment.
Good ideas, thank you. There is a competing strategy to this one where we use multiple jobs in the workflow that run in || against groups of tests. We can try this first using xdist in 1 job.
Move PD preview startup out of conftest into pd_server.py with make serve-pd. Pytest discovers an existing server for xdist. CI uses js/setup and make test-pd-local (no separate dist step or CI-only bash). Co-authored-by: Cursor <cursoragent@cursor.com>
alexjoel42
force-pushed
the
deployment_time_saver
branch
from
23afa07 to
3110a62
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Broke pd_server out of conftest.py and added Xdist
https://opentrons.atlassian.net/browse/RQA-5458
Python/Make setup edits
Testing