fix(app, app-shell) fix the purple outline rendering condition

[koji]

Overview

utilize the hover by adding selectedSlot to keep the purple outline when a user opens the secondary window.
i don't update protocol-visualization because of spotlight window. it is a browser base so the function to handle the purple outline would need a different implementation when closing the spotlight window.

hover_protocol-visualization.mov

Test Plan and Hands on Testing

• go to visualization page
• click slot and open spotlight window
  check that the deck view displays the purple outline on the slot you clicked
• close the spotlight window
  check that the purple outline on the deck view will disappear

Changelog

• update the condition
• add the close function to handle the purple outline

Review requests

Risk assessment

low

[codecov]

Codecov Report

❌ Patch coverage is 53.33333% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 21.29%. Comparing base (1a1f34e) to head (f9659b5).
⚠️ Report is 1 commits behind head on chore_release-9.1.0.

Files with missing lines	Patch %	Lines
...rotocolVisualization/VisualizerContainer/index.tsx	40.00%	1 Missing and 2 partials ⚠️
app/src/redux/shell/reducer.ts	50.00%	2 Missing ⚠️
...olVisualization/DeckView/DeckViewOverlay/index.tsx	0.00%	1 Missing ⚠️
app/src/redux/shell/actions.ts	66.66%	1 Missing ⚠️

Additional details and impacted files

@@                   Coverage Diff                   @@
##           chore_release-9.1.0   #21598      +/-   ##
=======================================================
- Coverage                21.36%   21.29%   -0.08%     
=======================================================
  Files                     3865     3865              
  Lines                   323481   323493      +12     
  Branches                 58203    58575     +372     
=======================================================
- Hits                     69124    68879     -245     
- Misses                  251313   251588     +275     
+ Partials                  3044     3026      -18     

Flag	Coverage Δ
app	46.02% <53.33%> (-0.42%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
app-shell/src/constants.ts	45.21% <100.00%> (+0.29%)	⬆️
app-shell/src/main.ts	0.00% <ø> (ø)
app-shell/src/secondary-windows/index.ts	0.00% <ø> (ø)
.../src/secondary-windows/step-detail-viewer/index.ts	0.00% <ø> (ø)
...ProtocolVisualization/DeckView/DeckViewDetails.tsx	0.00% <ø> (ø)
...ProtocolVisualization/DeckView/DeckViewLabware.tsx	0.00% <ø> (ø)
...ProtocolVisualization/DeckView/DeckViewModules.tsx	0.63% <ø> (ø)
...p/ProtocolVisualization/DeckView/DeckViewSlots.tsx	0.00% <ø> (ø)
...ProtocolVisualization/DeckView/DeckViewStacker.tsx	1.86% <ø> (ø)
...s/Desktop/ProtocolVisualization/DeckView/index.tsx	1.61% <ø> (ø)
... and 5 more

... and 11 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[sfoster1]

Let's just get some utility functions for the protocol key / window id thing, but it looks fine to me otherwise.

unrelated to merging this pr, how do changes of this kind work with the separate protocol visualizer project? does it not matter because the separate project doesn't have secondary windows?

[sfoster1]

we should have some shared functions that (1) set the window id from the protocol key (2) get the protocol key from the window id. this is very prone to someone making a small change and breaking things in a way that linting, typechecking, and tests will not catch