Skip to content

feat(protocol-designer): extend mainifold compatibility to accommodate direct wellplate#21639

Draft
ncdiehl11 wants to merge 2 commits into
edgefrom
pd_extend-manifold-lw
Draft

feat(protocol-designer): extend mainifold compatibility to accommodate direct wellplate#21639
ncdiehl11 wants to merge 2 commits into
edgefrom
pd_extend-manifold-lw

Conversation

@ncdiehl11
Copy link
Copy Markdown
Collaborator

Overview

This PR extends the manifold to accommodate a collection plate directly (valid combination, bottom up: collectin plate, filter plate, collar)

Test Plan and Hands on Testing

Describe your testing of the PR. Emphasize testing not reflected in the code. Attach protocols, logs, screenshots and any other assets that support your testing.

Changelog

List changes introduced by this PR considering future developers and the end user. Give careful thought and clear documentation to breaking changes.

Review requests

  • What do you need from reviewers to feel confident this PR is ready to merge?
  • Ask questions.

Risk assessment

  • Indicate the level of attention this PR needs.
  • Provide context to guide reviewers.
  • Discuss trade-offs, coupling, and side effects.
  • Look for the possibility, even if you think it's small, that your change may affect some other part of the system.
    • For instance, changing return tip behavior may also change the behavior of labware calibration.
  • How do your unit tests and on hands on testing mitigate this PR's risks and the risk of future regressions?
  • Especially in high risk PRs, explain how you know your testing is enough.

ncdiehl11 added 2 commits June 2, 2026 10:59
…e direct wellplate

This PR extends the manifold to accommodate a collection plate directly (valid combination, bottom
up: collectin plate, filter plate, collar)
@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 2, 2026

Codecov Report

❌ Patch coverage is 13.04348% with 20 lines in your changes missing coverage. Please review.
✅ Project coverage is 21.62%. Comparing base (c22bcad) to head (7189c7f).

Files with missing lines Patch % Lines
.../src/pages/Designer/DeckSetup/DeckSetupToolbox.tsx 0.00% 10 Missing ⚠️
.../components/organisms/SelectLabwareModal/index.tsx 42.85% 4 Missing ⚠️
...col-designer/src/pages/Designer/DeckSetup/utils.ts 0.00% 4 Missing ⚠️
...rc/pages/Designer/DeckSetup/DeckSetupContainer.tsx 0.00% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             edge   #21639   +/-   ##
=======================================
  Coverage   21.62%   21.62%           
=======================================
  Files        3907     3907           
  Lines      320262   320276   +14     
  Branches    57770    57779    +9     
=======================================
+ Hits        69246    69272   +26     
+ Misses     248046   248034   -12     
  Partials     2970     2970           
Flag Coverage Δ
protocol-designer 39.52% <13.04%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...designer/src/pages/Designer/DeckSetup/constants.ts 10.00% <ø> (ø)
...l-designer/src/utils/labwareModuleCompatibility.ts 11.19% <ø> (ø)
...rc/pages/Designer/DeckSetup/DeckSetupContainer.tsx 17.03% <0.00%> (ø)
.../components/organisms/SelectLabwareModal/index.tsx 31.81% <42.85%> (+6.96%) ⬆️
...col-designer/src/pages/Designer/DeckSetup/utils.ts 16.52% <0.00%> (ø)
.../src/pages/Designer/DeckSetup/DeckSetupToolbox.tsx 29.31% <0.00%> (-0.66%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant