refactor(app): Delete defunct Redux code for toggling the lights#21684
Open
SyntaxColoring wants to merge 2 commits into
Open
refactor(app): Delete defunct Redux code for toggling the lights#21684SyntaxColoring wants to merge 2 commits into
SyntaxColoring wants to merge 2 commits into
Conversation
SyntaxColoring
requested review from
a team and
jerader
and removed request for
a team
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This code was totally unused: nobody dispatched these actions or called these selectors. It's been replaced by
useLightsQuery()anduseLightsMutation()in react-api-client.600 lines across 15 files for an effing toggle switch. My god.
This goes towards (but does not close) AUTH-2971.
Test Plan and Hands on Testing
Just CI.
Review requests
None.
Risk assessment
Low.