Skip to content

raidboss: add support for The Merchant's Tale (Advanced)#1071

Open
ForestSageSarah wants to merge 10 commits into
OverlayPlugin:mainfrom
ForestSageSarah:pari-of-plenty-raidboss
Open

raidboss: add support for The Merchant's Tale (Advanced)#1071
ForestSageSarah wants to merge 10 commits into
OverlayPlugin:mainfrom
ForestSageSarah:pari-of-plenty-raidboss

Conversation

@ForestSageSarah

Copy link
Copy Markdown

Adds initial raidboss support for Pari of Plenty in The Merchant's Tale (Advanced).

Included:

  • Heat Burst raidwide
  • Scouring Scorn raidwide
  • Fire of Victory tankbuster
  • Sun Circlet raidwide w/ Safe Spot
  • Doubling / False Flame North/South Safe Spots
  • Charmed Chains tether partner callout & Center positioning reminder (on Doubling cast)

ToDo

  • Left/Right Fireflight Safe Spots
  • Fiery Bauble Safe Spots
  • Four Long Nights Tether Order/Safe Spots

@JLGarber JLGarber left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for putting all this together. I don't know how much the regular maintainers here do the Variant/Criterion content, so we really appreciate anyone else willing to work on it. Do you know whether you're likely to be able to put all the timelines for Advanced together? I can check through my logs to see whether there's anything useful there.

Can you clarify the source of your translations? I can read enough French/German to be comfortable with those, but I don't read our other supported languages. If you speak all of them, that's perfectly fine, but if any are machine-translated, let's leave those out and let the community translators handle them instead.

We appreciate your contribution!

Comment thread ui/raidboss/data/07-dt/dungeon/the_merchants_tale_advanced.ts Outdated
Comment thread ui/raidboss/data/07-dt/dungeon/the_merchants_tale_advanced.ts Outdated
Comment thread ui/raidboss/data/07-dt/dungeon/the_merchants_tale_advanced.txt Outdated
Comment thread ui/raidboss/data/07-dt/dungeon/the_merchants_tale_advanced.ts Outdated
@github-actions github-actions Bot removed the needs-review Awaiting review label Jun 4, 2026
@ForestSageSarah

Copy link
Copy Markdown
Author

@JLGarber

Thanks so much for putting all this together. I don't know how much the regular maintainers here do the Variant/Criterion content, so we really appreciate anyone else willing to work on it. Do you know whether you're likely to be able to put all the timelines for Advanced together? I can check through my logs to see whether there's anything useful there.

Thanks so much! I am planning on completing all three fights (Pari / Seamaid / Swordmaster) - would it have been better to wait until I had the baseline done for the other 3 to PR?

Can you clarify the source of your translations? I can read enough French/German to be comfortable with those, but I don't read our other supported languages. If you speak all of them, that's perfectly fine, but if any are machine-translated, let's leave those out and let the community translators handle them instead.

They are a mix of ML and directionals I grabbed from the Aloalo Island file I used as a template - definitely better for the community to translate instead then!

Co-authored-by: Jonathan Garber <linkthevaliant@gmail.com>
@github-actions github-actions Bot added the needs-review Awaiting review label Jun 4, 2026
ForestSageSarah and others added 2 commits June 4, 2026 09:17
Co-authored-by: Jonathan Garber <linkthevaliant@gmail.com>
Co-authored-by: Jonathan Garber <linkthevaliant@gmail.com>
@JLGarber

JLGarber commented Jun 4, 2026

Copy link
Copy Markdown
Collaborator

@ForestSageSarah

Thanks so much! I am planning on completing all three fights (Pari / Seamaid / Swordmaster) - would it have been better to wait until I had the baseline done for the other 3 to PR?

Typically we do try to make non-Ultimate pieces of content one self-contained package, or "one trigger package/one timeline package" etc, but if you're actively planning to handle the other bosses it probably doesn't matter too much. This is especially true for Advanced Variant, where bosses are encountered in a non-fixed order. That being said, I'll tag in @xiashtra here to assist with clarifying, since this isn't a situation we come across as much and I don't want to give an answer that's my opinion but doesn't fully align with the docs.

As for the translations, anything that's directly sourced from another file in the repository is fine, to be clear, so long as the mechanical handling matches exactly. (For example, if there's a specialized translation for a normal-mode raid's output strings, it is fine and expected to re-use that for Savage if it's unchanged mechanically.) What we generally want to avoid is machine translations for new text content.

@xiashtra

xiashtra commented Jun 6, 2026

Copy link
Copy Markdown
Collaborator

Thanks so much! I am planning on completing all three fights (Pari / Seamaid / Swordmaster) - would it have been better to wait until I had the baseline done for the other 3 to PR?

Typically we do try to make non-Ultimate pieces of content one self-contained package, or "one trigger package/one timeline package" etc, but if you're actively planning to handle the other bosses it probably doesn't matter too much. This is especially true for Advanced Variant, where bosses are encountered in a non-fixed order. That being said, I'll tag in @xiashtra here to assist with clarifying, since this isn't a situation we come across as much and I don't want to give an answer that's my opinion but doesn't fully align with the docs.

Either one PR for the entire instance or one PR per boss should be fine. It can be preferable to submit one PR per boss if it will take a while to finish all of them, so that they can be checked/approved and released incrementally.

netRegex: { effectId: '301' },
condition: Conditions.targetIsYou(),
suppressSeconds: 2,
response: Responses.breakChains(),

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
response: Responses.breakChains(),
response: Responses.breakChains(),

This will resolve the lint error. You should use the lint and test scripts locally to check your PR before submitting.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To follow up on this, most linting errors can be fixed automatically with npm run lintfix. Other npm run <foo>fix targets exist for other linting types as well.

@github-actions github-actions Bot removed the needs-review Awaiting review label Jun 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants