refactor: switch icon library from tabler to phosphor#44
Merged
Conversation
Swap the configured icon set in both component packages: - React: iconLibrary -> "phosphor", peer/dev dep @phosphor-icons/react; stories use the *Icon suffix (PlusIcon/ArrowRightIcon). - Angular: @ng-icons/phosphor-icons; stories import phosphor* glyphs from the /regular weight subpath. Update README, AGENTS.md, and the add-component skill docs to match.
loofpc
approved these changes
Jun 23, 2026
sjoerdbeentjes
added a commit
that referenced
this pull request
Jun 23, 2026
…cons Follow PR #44: replace all @tabler/icons-react usages in the new components and their stories with @phosphor-icons/react (`*Icon` suffix). The icon library config and peer/dev deps already came in via the rebase onto main.
sjoerdbeentjes
added a commit
that referenced
this pull request
Jun 24, 2026
…cons Follow PR #44: replace all @tabler/icons-react usages in the new components and their stories with @phosphor-icons/react (`*Icon` suffix). The icon library config and peer/dev deps already came in via the rebase onto main.
sjoerdbeentjes
added a commit
that referenced
this pull request
Jun 29, 2026
The vendored components shipped spartan's default @ng-icons/lucide glyphs while the design system standardized on Phosphor (React migrated in PR #44) and only the stories used it. Swap every component-side icon to its Phosphor equivalent (matching React's choices, e.g. CaretUpDown on the select trigger), promote @ng-icons/phosphor-icons to a runtime dependency, and remove @ng-icons/lucide from package.json and ng-package.json.
loofpc
pushed a commit
that referenced
this pull request
Jun 30, 2026
…cons Follow PR #44: replace all @tabler/icons-react usages in the new components and their stories with @phosphor-icons/react (`*Icon` suffix). The icon library config and peer/dev deps already came in via the rebase onto main.
loofpc
pushed a commit
that referenced
this pull request
Jun 30, 2026
The vendored components shipped spartan's default @ng-icons/lucide glyphs while the design system standardized on Phosphor (React migrated in PR #44) and only the stories used it. Swap every component-side icon to its Phosphor equivalent (matching React's choices, e.g. CaretUpDown on the select trigger), promote @ng-icons/phosphor-icons to a runtime dependency, and remove @ng-icons/lucide from package.json and ng-package.json.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Switches the design system's configured icon set from Tabler to Phosphor across both component packages and the docs.
What changed
React (
@surfnet/react)components.json→iconLibrary: "phosphor"@tabler/icons-reactto@phosphor-icons/react*Iconsuffix (PlusIcon,ArrowRightIcon)Angular (
@surfnet/angular)@ng-icons/tabler-icons→@ng-icons/phosphor-iconsphosphorPlus/phosphorArrowRightfrom@ng-icons/phosphor-icons/regularDocs: README, AGENTS.md, and the add-component skill (react.md + angular.md).
Reviewer notes
IconPlus), Phosphor suffixes (PlusIcon). v2 deprecates the barePlusexport.@ng-icons/phosphor-icons's main entry is empty — glyphs live under weight subpaths./regularis used as the Tabler-equivalent default.shadcnskill files were left untouched (they reference tabler only as a generic example, and AGENTS.md says not to hand-edit them).privateand never publish.pnpm build,pnpm lint, andpnpm formatall pass.