Fix GitHub Pages deployment workflow#31
Conversation
|
Warning Rate limit exceeded
You’ve run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe workflow file is restructured to replace a third-party GitHub Pages action with the official GitHub Pages artifact upload and deployment pipeline. The build and deploy responsibilities are separated into distinct jobs, concurrency is added to serialize deployments, and permissions are explicitly scoped for Pages and token access. ChangesGitHub Pages Workflow Refactoring
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/deploy-docs.yml:
- Around line 40-49: The uploaded Pages artifact is excluding the .nojekyll file
because actions/upload-pages-artifact@v4 defaults include-hidden-files to false;
update the Upload Pages artifact step (the action usage of
actions/upload-pages-artifact@v4) to set include-hidden-files: true so the
generated .nojekyll file is included in the artifact and Jekyll processing is
disabled as intended.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: a54f2479-0164-4cde-8810-fde6c9fc736c
📒 Files selected for processing (1)
.github/workflows/deploy-docs.yml
0d16242 to
1233a28
Compare
🐞 Problem to Solve
The existing docs deployment relies on pushing generated output to
gh-pages, which is brittle with the current GitHub Pages setup and can fail even when Dokka generation succeeds.💡 Solution
gh-pagesbranch deployment with the supported GitHub Pages artifact flowpagesandid-tokenpermissions.nojekyllto the generated Dokka output before upload🧪 Proof
Ran
./gradlew :lib:dokkaGenerate✅ Checklist
Summary by CodeRabbit