BED-8189: Update default admin email#303
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
WalkthroughTwo documentation snippets are updated to align the default admin email configuration: the ChangesDefault admin email configuration
🎯 1 (Trivial) | ⏱️ ~2 minutes
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
| "connection": "postgresql://bhe:bhe4eva@localhost/bhe" | ||
| }, | ||
| "default_admin": { | ||
| "principal_name": "admin", |
There was a problem hiding this comment.
Was there a reason principal_name was removed? It gets filled by default if missing, but it's an essential field and would probably be good to show in the example JSON configuration.
There was a problem hiding this comment.
@cami-specter, I thought I should remove it from the example because the docs above indicate that it is deprecated. Maybe that's a mistake though.
There was a problem hiding this comment.
Oh, I see. It's definitely not deprecated in the code and in our build.config.json.template which we use to set local configs (https://github.com/SpecterOps/BloodHound/blob/main/local-harnesses/build.config.json.template#L19), but there might be context I'm not aware of. Probably best to remove it then if it's marked as such!
There was a problem hiding this comment.
I'll see if I can find out more about why that was marked as deprecated in docs only.
Minor doc updates for next release related to BED-8189:
Summary by CodeRabbit
email_addressfield