Use persistent property in deferred IMGUI context-menu callbacks#66
Merged
VPDPersonal merged 1 commit intoJun 23, 2026
Conversation
e22ed96
into
feature/serialize-reference-dropdown
1 check passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GenericMenucallbacks in the IMGUI serialize-reference drawer that captured the stale per-framepropertyinstead of thepersistentsnapshot the drawer already builds for the menu.Create New Script…,Paste Template/*, andLink to Existing/*now read/write throughpersistent, so by click time they no longer dereference aSerializedObjectthat may have been disposed after the frame.Notes for review
LinkToreads its source viaproperty.serializedObject.FindProperty(sourcePath)and writes back on the sameSerializedObject; passingpersistentkeeps both sides on one live SO and preserves the sharedmanagedReferenceId.ApplyTemplatestill callsproperty.Persistent()internally — now harmlessly idempotent since it receives an already-persistent property, and the deferred callback dereferences a live SO.Linked issues
Refs #49 - addresses review finding #49 (comment)