Skip to content

Re-subscribe theme updates on attach for symmetric lifecycle #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
VPDPersonal merged 1 commit into from
Jun 23, 2026
Merged

Re-subscribe theme updates on attach for symmetric lifecycle #71

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions ...ols/Unity/Editor/Scripts/VisualElements/Internal/Styles/AspidThemeStyleSheetExtensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,9 @@ internal static class AspidThemeStyleSheetExtensions
/// Adds <see cref="AspidStyles.DefaultStyleSheet"/> to the element and, when the user has
/// configured one, layers <see cref="AspidThemeSettings.OverrideStyleSheet"/> on top of it.
/// The override is added to the same element as the base palette so its <c>:root</c> tokens
/// take precedence. The element re-applies the override live whenever
/// <see cref="AspidThemeSettings.Changed"/> fires and unsubscribes when it leaves the panel.
/// take precedence. The element subscribes to <see cref="AspidThemeSettings.Changed"/> while
/// attached to a panel (re-applying the current override on attach) and unsubscribes when it
/// leaves the panel, so live updates survive detach/reattach and never leak when never attached.
/// </summary>
/// <param name="element">The element that receives the theme style sheets.</param>
/// <returns>The element, for chaining.</returns>
Expand All @@ -34,7 +35,11 @@ void OnThemeChanged()
if (applied != null) element.AddStyleSheets(applied);
}

AspidThemeSettings.Changed += OnThemeChanged;
element.RegisterCallback<AttachToPanelEvent>(_ =>
{
OnThemeChanged();
AspidThemeSettings.Changed += OnThemeChanged;
});
element.RegisterCallback<DetachFromPanelEvent>(_ => AspidThemeSettings.Changed -= OnThemeChanged);

return element;
Expand Down
Loading