Distinguish absent vs empty required field in YAML gate#73
Merged
VPDPersonal merged 1 commit intoJun 23, 2026
Merged
Conversation
b82a2d7
into
feature/serialize-reference-dropdown
1 check passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SerializeReferenceYamlEditor.FindUnsetRequiredFields) no longer treats a totally absent top-level field key as a violation. Unity omits a serialized field from YAML when the object was last saved before the[TypeSelector(Required = true)]field was added (and for stripped / nested-prefab docs), so the old behavior produced a CI false-positive (-srGateRequiredatFailseverity exited 1 on a project that is valid once reopened).FieldState(Absent/PresentSet/PresentUnset); onlyPresentUnsetis reported. An absent key is left for a reserialize, which is exactly how the object-load path (which can read defaulted properties) already behaves.Notes for review
SerializeReferenceRequiredGate.IsViolation/CollectRequiredViolations) is intentionally unchanged: it walks liveSerializedObjectproperties, where every declared field is present (Unity reserializes on load), so it has no absent-key false-positive. The asymmetry is the point — the YAML scan can't reserialize, so it must not flag what it can't see.Is…Unsetnames despite now returning a tri-state enum; they have no other callers, so renaming would be churn outside this finding's scope.Linked issues
Refs #49 - addresses review finding #49 (comment)