Share per-frame state between GetHeight and Draw#74
Merged
VPDPersonal merged 1 commit intoJun 23, 2026
Merged
Conversation
7762e07
into
feature/serialize-reference-dropdown
1 check passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
[SerializeReference]IMGUI drawer askedHasSharedReferencefor every managed-reference field from bothGetHeightandDrawon each repaint, and each call did a fullSerializedObjectwalk —2·Nwhole-object walks per frame.HasSharedReferencenow builds the object's managed-reference id → use-count once per(SerializedObject, frame)and reuses it, so the object is walked once per repaint instead of2·Ntimes.SerializeReferenceRequiredGate.ResolveFieldInfonow memoises its reflection walk by(target type, property path)— like the existingRequiredFieldCache— soIsViolation/TryGetRequired(also called from bothGetHeightandDraw) reflect each path once instead of re-walking it every frame.Notes for review
count > 1means at least one other field aliases it. The existingmanagedReferenceValue is nullguard still short-circuits empty references first.Time.frameCount+ theSerializedObjectreference; an in-frame mutation (e.g.MakeReferenceUnique) is applied via a button click that ends the draw and rebuilds the inspector next frame, so the cache rebuilds then — same staleness tolerance as the existing per-selection_mixedResultmemo.ResolveFieldInfocache is static and never explicitly cleared, which matchesRequiredFieldCachein the same class: the reflected field set is stable until a domain reload wipes statics.Linked issues
Refs #49 - addresses review finding #49 (comment)