Filter nested generic definitions by all generic constraints#78
Merged
VPDPersonal merged 1 commit intoJun 23, 2026
Conversation
08aa26a
into
feature/serialize-reference-dropdown
1 check passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
BuildParamPageover-broadening the nested open-generic list for a type parameter with multiple base constraints (where T : Base, IFoo).object) before fetching nested definitions, pass the fullbaseTypestoGetAssignableGenericDefinitionsso the candidate defs are narrowed by every constraint up front — no more dead-end picks that end in an inline "Cannot construct…" error.Notes for review
GetAssignableGenericDefinitions(fieldType, params Type[] narrowTypes)checks closeability againstfieldTypeand each narrowing type;GetConstraintBaseTypesnever returns an empty array (it falls back to{ typeof(object) }), sobaseTypes[0]is safe andobjectentries are ignored by the narrowing filter.constraintTypeis left untouched — it still backs thePickerPage.ConstraintTypeused downstream.Linked issues
Refs #49 - addresses review finding #49 (comment)