vmscrapeconfig: add absent sd configs#2283
Merged
Merged
Conversation
AndrewChubatiuk
changed the title
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
1 issue found across 10 files
Reply with feedback, questions, or to request a fix.
Fix all with cubic | Re-trigger cubic
AndrewChubatiuk
force-pushed
the
add-lacking-sd-configs
branch
from
bba4604 to
e017a5d
Compare
…mSDConfigs, marathonSDConfigs, and yandexCloudSDConfigs
AndrewChubatiuk
force-pushed
the
add-lacking-sd-configs
branch
from
e017a5d to
0b263ce
Compare
vrutkovs
approved these changes
Jun 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #2265
Summary by cubic
Adds support for new service discovery types in
VMScrapeConfigto reach full parity with VictoriaMetricssd_configs, and fixes a potential deadlock in the operator metrics collector. Addresses #2265.New Features
consulAgentSDConfigs,dockerSDConfigs,dockerSwarmSDConfigs,marathonSDConfigs,yandexCloudSDConfigs.internal/controller/operator/factory/vmscrapes/scrapeconfig.go.Bug Fixes
operator_object_statuscollector by not holding the mutex during metric emission.Written for commit 0b263ce. Summary will update on new commits.