Fix method signature rendering fidelity in TypePrinter#102
Open
matejcerny wants to merge 1 commit into
Open
Conversation
Author
|
cc @rochala 🙏 |
Contributor
|
Thanks for contribution. I'll take a look at it during the weekend. Sorry for the delay 🙈 |
Author
No worries! I would really like to help more with Cellar, as there are quite a few places that could be improved. Also, it's currently the backbone of agentic programming in Scala, so I guess it deserves more love 🙂 |
Author
|
FYI I've already spent some time and tokens on:
I'll create separate PR's in case you agree that "this is the way" 🙂 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #101.
:(fa: F[A])(f: ...)) instead of(fa: F[A]): (f: ...):separator is now emitted only before a genuine (non-methodic) result type.[A, B]renders as[A, B]again rather than[A >: Nothing <: Any, B >: Nothing <: Any]Nothing/Anyrather than its rawtoString.Additional rendering fixes
Function1[A, B]now renders asA => BandContextFunctionNas?=> ..., with parentheses added where required - around a function-typed left operand ((A => B) => C) and around arrow sugar inextendsposition.implicitkeyword (previously onlyusingwas handled).Tests
Added
TypePrinterunit tests plus Scala 2 and Scala 3 fixtures (CellarCurried,CellarSugar) covering:using/implicitparametersUpdated the README example output to match.