Make playlist waveform an inner block#78988
Draft
scruffian wants to merge 2 commits into
Draft
Conversation
|
Size Change: +552 B (+0.01%) Total Size: 8.21 MB 📦 View Changed
|
… class injection - Reuse the existing waveform block (and migrate the playlist's is-style-* class for legacy markup) when normalizing/rebuilding inner blocks, so the selected waveform style is not lost. - Inject the waveform player with a literal str_replace so user-provided class names containing `$`/`\` are not treated as preg_replace backreferences. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
Flaky tests detected in f942f96. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/27038184374
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
No linked issue.
Makes the playlist waveform a dedicated inner block so waveform block styles no longer occupy the playlist block's own style variations.
Why?
This allows the playlist block itself to support other block styles while the waveform visualization keeps its Bars, Mirror, Line, Blocks, Dots, and Seekbar styles.
How?
Adds
core/playlist-waveformandcore/playlist-tracklist, normalizes older direct track children in the editor, and keeps server rendering compatible with legacy playlist markup while reading waveform styles from the waveform child when present.Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast
Not included.
Use of AI Tools
Drafted with OpenAI Codex and reviewed by the contributor.
Validation
git diff --check, PHP syntax checks for touched PHP files, andnode --checkfor touched JS files passed; PHPUnit, PHPCS, full JS lint, and wp-env testing could not run in this workspace because dependencies/Docker were unavailable.