pbkit: Dynamically compute PTIMER parameters#775
Open
thrimbor wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split out from other pbkit changes, original commit is thrimbor@3a1faf3
It's what I consider a proper solution for the PTIMER initialization issue, deriving the parameters from the chip register values like #695 did for the performance counters, instead of only using them for checking assumptions like it is now.
On a stock Xbox it results in a 31.25MHz PTIMER frequency like the XDK has hard-coded, and it should manage to configure the same frequency on an overclocked system, though I only was able to test the former.
Fixes #536
Supersedes #621, which I don't consider good enough because it only removes the check without attempting to handle what it checked for.