Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #49 +/- ##
==========================================
+ Coverage 97.30% 97.39% +0.08%
==========================================
Files 41 42 +1
Lines 2489 2572 +83
==========================================
+ Hits 2422 2505 +83
Misses 67 67 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
No issues found across 5 files
Confidence score: 5/5
- Automated review surfaced no issues in the provided summaries.
- No files require special attention.
Requires human review: This PR introduces a new feature (InformationImbalanceEstimator) with significant logic and a new public API, which warrants human review for implementation correctness and design.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Key insights about the PR.
Linked Issues
Checklist
Summary by cubic
Adds
InformationImbalanceEstimatorfor directional representation similarity using nearest-neighbor ranks, addressing #34. Exposes it intdhook.latent, updates the representation similarity notebook with an Information Imbalance section, and adds tests.tdhook.latent.representation_similarity.InformationImbalanceEstimatorcomputingA→BandB→Afrom nearest-neighbor rank preservation.(N, D)and batched(..., N, D), configurablep, dtype promotion, and input validation (matching batch shapes/devices,N≥2).tdhook.latentandtdhook.latent.representation_similarity; notebook adds examples and API notes alongsideCkaEstimator.Written for commit a38cf63. Summary will update on new commits.