Fix: websocket url parser#326
Open
fdelpoggio wants to merge 2 commits into
Open
Conversation
| */ | ||
| public static DslWriteSampler websocketWrite(String requestData) { | ||
| return new DslWriteSampler(requestData); | ||
| public static DslWriteSampler websocketWrite(String requestData, String dataType) { |
Collaborator
There was a problem hiding this comment.
consider use an Enum for type, in caso it field could be a JMeter variable maybe you should expose both methods
public static DslWriteSampler websocketWrite(String requestData, String dataType)
and
public static DslWriteSampler websocketWrite(String requestData, DataType dataType)
| */ | ||
| public static DslReadSampler websocketRead() { | ||
| return new DslReadSampler(); | ||
| public static DslReadSampler websocketRead(String type) { |
Collaborator
There was a problem hiding this comment.
Same comment as before
| */ | ||
| public static DslWriteSampler websocketWrite(String requestData) { | ||
| return new DslWriteSampler(requestData); | ||
| public static DslWriteSampler websocketWrite(String requestData, String dataType) { |
Collaborator
There was a problem hiding this comment.
Also add a default method without dataType param using text as default
| private String dataType; | ||
|
|
||
| private DslWriteSampler(String requestData) { | ||
| private DslWriteSampler(String requestData, String dataType) { |
Collaborator
There was a problem hiding this comment.
Same comment regarding to data type
| String scheme = uri.getScheme(); | ||
| if (scheme == null || (!"ws".equals(scheme) && !"wss".equals(scheme))) { | ||
| private void parseUrl(String url) { | ||
| JmeterUrl parsed = JmeterUrl.valueOf(url); |
Collaborator
There was a problem hiding this comment.
what happen if url string is full variable?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix the WebSocket URL parser and add text/binary data type to WebSocket read and write sampler