Skip to content

Switch to nbclassic and Python 3.12.11#479

Merged
danielhollas merged 57 commits into
mainfrom
nbclassic
Jun 3, 2026
Merged

Switch to nbclassic and Python 3.12.11#479
danielhollas merged 57 commits into
mainfrom
nbclassic

Conversation

@danielhollas

@danielhollas danielhollas commented Jul 14, 2024

Copy link
Copy Markdown
Contributor

fixes #552

We switch to nbclassic interface, which is now supported in appmode.

Notebook v7 is currently not supported in Appmode.

@yakutovicha yakutovicha changed the title WIP: Switch to nbclassic Switch to nbclassic and Python 3.11.10 Nov 11, 2025
@yakutovicha yakutovicha changed the title Switch to nbclassic and Python 3.11.10 Switch to nbclassic and Python 3.12.11 Mar 10, 2026
@yakutovicha yakutovicha marked this pull request as ready for review March 16, 2026 11:05
@yakutovicha

Copy link
Copy Markdown
Member

@edan-bainglass, @danielhollas - this one is ready, please test 🙏

@edan-bainglass edan-bainglass left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left comments

PSQL_START_CMD="pg_ctl --timeout=180 -w -l ${PSQL_LOGFILE} start"

MAMBA_RUN="mamba run -n aiida-core-services"
CONDA_RUN="conda run -n aiida-core-services"

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The time I tried, Mamba was just hanging and not moving forward, so I switched to conda to make it work.

I can try to revert it and see how it goes this time.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please try. If it fails, good to understand why.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here it is: #479 (comment)

Comment thread stack/base/Dockerfile Outdated
Comment thread stack/lab/Dockerfile Outdated
Comment thread stack/lab/Dockerfile Outdated
Comment thread stack/lab/Dockerfile
@danielhollas danielhollas added blocked This issue/PR is blocked by another issue/PR. labels Apr 10, 2026
@danielhollas

Copy link
Copy Markdown
Contributor Author

This is very minor, but I am seeing this warning when using pip in this image

image

We can add ENV PIP_USE_FEATURE="build-constraint" in the base image to get rid of it (where we set PIP_CONSTRAINT).

@danielhollas

danielhollas commented May 1, 2026

Copy link
Copy Markdown
Contributor Author

Marking this as blocked until #510 is merged (hope to make some progress on that over weekend) and we need to first release the 2.8 based image anyway.

The RMQ update has been merged and I've updated this PR here. The changes here look good to me, but I think we should release a new image with aiida-core 2.8.0 before merging this, see #564. I've also discussed with @yakutovicha that it would be good to do a bit more testing, in particular to have at least one app upgraded and confirmed working, so that we do not run into any further surprises.

Please also address my previous comments: (EDIT: I've done the first two)

@danielhollas danielhollas removed the blocked This issue/PR is blocked by another issue/PR. label May 27, 2026

@danielhollas danielhollas left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think once we make the aiidalab-home release we can merge this.

@danielhollas danielhollas merged commit b45727e into main Jun 3, 2026
20 checks passed
@danielhollas danielhollas deleted the nbclassic branch June 3, 2026 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support nbclassic and Python 3.12

3 participants