Skip to content

Fix SQL value checks for negative expected values#69893

Open
nailo2c wants to merge 1 commit into
apache:mainfrom
nailo2c:fix-sql-value-check-negative-tolerance
Open

Fix SQL value checks for negative expected values#69893
nailo2c wants to merge 1 commit into
apache:mainfrom
nailo2c:fix-sql-value-check-negative-tolerance

Conversation

@nailo2c

@nailo2c nailo2c commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

Hi team, I found a bug in SQLValueCheckOperator.

If numeric_pass_value_conv=-100 and self.tol=0.1, the resulting range is -90 <= record <= -110, which I don't think matches the expected behavior.


Was generative AI tooling used to co-author this PR?
  • No (please specify the tool below)

  • Read the Pull Request Guidelines for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
  • For fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
  • When adding dependency, check compliance with the ASF 3rd Party License Policy.
  • For significant user-facing changes create newsfragment: {pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.

@nailo2c
nailo2c marked this pull request as ready for review July 15, 2026 05:39
@potiuk potiuk added the ready for maintainer review Set after triaging when all criteria pass. label Jul 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants