Secure AWS auth cookies behind TLS proxies#69898
Merged
pierrejeambrun merged 2 commits intoJul 15, 2026
Merged
Conversation
TLS is commonly terminated upstream, leaving api.ssl_cert empty even though browsers reach Airflow over HTTPS.
boring-cyborg
Bot
added
area:providers
provider:amazon
Contributor
Author
|
Could a maintainer please rerun the failed Static checks job? It failed in the unrelated FAB migration-reference hook, while the Amazon provider checks passed. |
Member
Done |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The AWS auth manager determined the JWT cookie's
Secureflag only fromapi.ssl_cert. Deployments terminating TLS at a reverse proxy normally leavethat setting empty, causing the login callback to emit a non-Secure session
cookie even when the request scheme is HTTPS.
This applies the proxy-aware scheme-or-certificate check already used by the
core, FAB, and Keycloak auth managers. It also adds regression coverage for an
HTTPS request without a locally configured certificate.
related: #47878
Validation
Was generative AI tooling used to co-author this PR?