Skip to content

Fix HttpSensor deferrable error allowlist#69904

Draft
Tomeshwari-02 wants to merge 1 commit into
apache:mainfrom
Tomeshwari-02:fix-http-sensor-allowlist
Draft

Fix HttpSensor deferrable error allowlist#69904
Tomeshwari-02 wants to merge 1 commit into
apache:mainfrom
Tomeshwari-02:fix-http-sensor-allowlist

Conversation

@Tomeshwari-02

Copy link
Copy Markdown

What changed

HttpSensor now passes its configured response_error_codes_allowlist into HttpSensorTrigger when running in deferrable mode.

HttpSensorTrigger now serializes that allowlist and uses it when deciding whether an HTTP error should keep waiting. Non-allowlisted HTTP errors are no longer silently retried in a tight loop.

Closes #69903

Why

The synchronous HttpSensor path honored custom allowlisted status codes such as 503, but the deferrable trigger path only retried 404. This made the same sensor configuration behave differently after deferral.

Tests

  • python -m py_compile providers/http/src/airflow/providers/http/sensors/http.py providers/http/src/airflow/providers/http/triggers/http.py providers/http/tests/unit/http/sensors/test_http.py providers/http/tests/unit/http/triggers/test_http.py
  • git diff --check

I could not run the focused pytest file in this local shell because the Airflow test dependencies are not installed (tests_common first, then time_machine).

@boring-cyborg

boring-cyborg Bot commented Jul 15, 2026

Copy link
Copy Markdown

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our prek-hooks will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example Dag that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

HttpSensor deferrable mode ignores response_error_codes_allowlist

1 participant