Fix HttpSensor deferrable error allowlist#69904
Draft
Tomeshwari-02 wants to merge 1 commit into
Draft
Conversation
|
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
HttpSensornow passes its configuredresponse_error_codes_allowlistintoHttpSensorTriggerwhen running in deferrable mode.HttpSensorTriggernow serializes that allowlist and uses it when deciding whether an HTTP error should keep waiting. Non-allowlisted HTTP errors are no longer silently retried in a tight loop.Closes #69903
Why
The synchronous
HttpSensorpath honored custom allowlisted status codes such as503, but the deferrable trigger path only retried404. This made the same sensor configuration behave differently after deferral.Tests
python -m py_compile providers/http/src/airflow/providers/http/sensors/http.py providers/http/src/airflow/providers/http/triggers/http.py providers/http/tests/unit/http/sensors/test_http.py providers/http/tests/unit/http/triggers/test_http.pygit diff --checkI could not run the focused pytest file in this local shell because the Airflow test dependencies are not installed (
tests_commonfirst, thentime_machine).