Skip to content

Split airflowctl dags state argument into run_id and --logical-date#69915

Draft
FrankYang0529 wants to merge 1 commit into
apache:mainfrom
FrankYang0529:airflow-dags-state
Draft

Split airflowctl dags state argument into run_id and --logical-date#69915
FrankYang0529 wants to merge 1 commit into
apache:mainfrom
FrankYang0529:airflow-dags-state

Conversation

@FrankYang0529

Copy link
Copy Markdown
Member

Why

  • Followup from Add airflowctl tasks failed-deps command #69397 (comment).
  • The core airflow dags state used single field logical_date_or_run_id for two different values. The airflowctl dags state inherited it.
  • If the input is a logical_date, it spends an extra request trying it as a run_id first. That request is bound to 404, and the CLI then uses the list API to retrieve the dag_run. An unknown run_id has a similar issue: the 404 is followed by a list call issued only to check that the Dag exists.

How

  • Add --logical-date and make run_id an optional positional. Exactly one of the two is required.
  • run_id goes straight to dag_runs.get and --logical-date goes to dag_runs.list.

Verification

  • uv run --project airflow-ctl pytest airflow-ctl/tests/airflow_ctl/ctl/commands/test_dag_command.py airflow-ctl/tests/airflow_ctl/api/test_operations.py

Was generative AI tooling used to co-author this PR?
  • Yes - Claude Code

  • Read the Pull Request Guidelines for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
  • For fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
  • When adding dependency, check compliance with the ASF 3rd Party License Policy.
  • For significant user-facing changes create newsfragment: {pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.

Signed-off-by: PoAn Yang <payang@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant