Skip to content

Update applemenu module to use only JDK Desktop APIs.#9245

Open
neilcsmith-net wants to merge 1 commit intoapache:masterfrom
neilcsmith-net:applemenu
Open

Update applemenu module to use only JDK Desktop APIs.#9245
neilcsmith-net wants to merge 1 commit intoapache:masterfrom
neilcsmith-net:applemenu

Conversation

@neilcsmith-net
Copy link
Member

Update the macOS-only applemenu module to remove legacy code and binaries.

Merge adapters to only use JDK APIs.
Remove use of external binaries.
Update to release 17.
@neilcsmith-net neilcsmith-net requested a review from mbien March 4, 2026 16:24
@neilcsmith-net neilcsmith-net added Platform [ci] enable platform tests (platform/*) os:macos ci:dev-build [ci] produce a dev-build zip artifact (7 days expiration, see link on workflow summary page) labels Mar 4, 2026
@mbien
Copy link
Member

mbien commented Mar 4, 2026

cool! There might be another small apple related cleanup (potentially separate)

final Class<?> fmClz = Class.forName("com.apple.eio.FileManager"); //NOI18N

This usage is (hopefully) the only reason we need the --add-exports=java.desktop/com.apple.eio=ALL-UNNAMED flag for.

I believe this can be achieved with Desktop.getDesktop().open(directory); these days, no? Would remove a flag and a startup warning on non-mac systems.

@mbien mbien added the Code cleanup Label for cleanup done on the Netbeans IDE label Mar 4, 2026
@mbien mbien added this to the NB30 milestone Mar 4, 2026
@neilcsmith-net
Copy link
Member Author

IMO, both the finder and the minimize action should be reviewed and possibly removed from this module. The finder one should be replaced with an all-OS action to open the file in the native file browser. Why does only macOS get this? People have requested this elsewhere. And the minimize one doesn't seem to work as it's shadowed by something else.

Had deliberately left those alone for now.

Copy link
Member

@mbien mbien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code looks good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci:dev-build [ci] produce a dev-build zip artifact (7 days expiration, see link on workflow summary page) Code cleanup Label for cleanup done on the Netbeans IDE os:macos Platform [ci] enable platform tests (platform/*)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants