Update applemenu module to use only JDK Desktop APIs.#9245
Open
neilcsmith-net wants to merge 1 commit intoapache:masterfrom
Open
Update applemenu module to use only JDK Desktop APIs.#9245neilcsmith-net wants to merge 1 commit intoapache:masterfrom
neilcsmith-net wants to merge 1 commit intoapache:masterfrom
Conversation
Merge adapters to only use JDK APIs. Remove use of external binaries. Update to release 17.
Member
|
cool! There might be another small apple related cleanup (potentially separate) This usage is (hopefully) the only reason we need the I believe this can be achieved with |
Member
Author
|
IMO, both the finder and the minimize action should be reviewed and possibly removed from this module. The finder one should be replaced with an all-OS action to open the file in the native file browser. Why does only macOS get this? People have requested this elsewhere. And the minimize one doesn't seem to work as it's shadowed by something else. Had deliberately left those alone for now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update the macOS-only applemenu module to remove legacy code and binaries.