HDDS-14718. Update Remaining Allocatable to consider Free Space To Spare#9826
Open
ssulav wants to merge 4 commits intoapache:masterfrom
Open
HDDS-14718. Update Remaining Allocatable to consider Free Space To Spare#9826ssulav wants to merge 4 commits intoapache:masterfrom
ssulav wants to merge 4 commits intoapache:masterfrom
Conversation
Contributor
sreejasahithi
left a comment
sreejasahithi
left a comment
There was a problem hiding this comment.
Thanks @ssulav for fixing this.
...cli-admin/src/test/java/org/apache/hadoop/hdds/scm/cli/datanode/TestUsageInfoSubcommand.java
Outdated
Show resolved
Hide resolved
Contributor
siddhantsangwan
left a comment
siddhantsangwan
left a comment
There was a problem hiding this comment.
Just one comment below.
Comment on lines
+158
to
+159
| info.getRemainingAllocatable() + " B", | ||
| StringUtils.byteDesc(info.getRemainingAllocatable())); |
Contributor
There was a problem hiding this comment.
To make it even easier to understand for the user, we can add the formula used for calculating remainingAllocatable as a helpful string in brackets. Some of the fields above are doing the same.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
In the datanode usgae info, update Remaining Allocatable to also consider Free Space To Spare.
Right now, it is showing the capacity only in the allocatable which is not totally true, as min free space to spare should be excluded.
What is the link to the Apache JIRA
HDDS-14718
How was this patch tested?
It is to be tested manually.